Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1849)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_event_router.cc

Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@initial_simplify
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_event_router.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_event_router.cc b/chrome/browser/extensions/api/tabs/tabs_event_router.cc
index 188e2e9c65b8e6f33e6f1346e4bd1100ee5e52d0..89c04e9f4a51ccb0cc4fc7b598aec695d1a2eeee 100644
--- a/chrome/browser/extensions/api/tabs/tabs_event_router.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_event_router.cc
@@ -546,12 +546,13 @@ void TabsEventRouter::OnZoomChanged(
EventRouter::USER_GESTURE_UNKNOWN);
}
-void TabsEventRouter::OnFaviconAvailable(const gfx::Image& image) {
-}
-
-void TabsEventRouter::OnFaviconUpdated(favicon::FaviconDriver* favicon_driver,
- bool icon_url_changed) {
- if (icon_url_changed) {
+void TabsEventRouter::OnFaviconUpdated(
+ favicon::FaviconDriver* favicon_driver,
+ NotificationIconType notification_icon_type,
+ const GURL& icon_url,
+ bool icon_url_changed,
+ const gfx::Image& image) {
+ if (notification_icon_type == NON_TOUCH_16_DIP && icon_url_changed) {
favicon::ContentFaviconDriver* content_favicon_driver =
static_cast<favicon::ContentFaviconDriver*>(favicon_driver);
FaviconUrlUpdated(content_favicon_driver->web_contents());

Powered by Google App Engine
This is Rietveld 408576698