Issue 1407333006: Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1407333006: Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths. Unfortunately we have to make coveringExpressionOffsets and coveringExpressionLengths optional. Otherwise new clients cannot correctly parse responses from old servers. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/069ba985de7e6e1c83d07c539a56935f05924889

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -34 lines)			Patch
M	pkg/analysis_server/doc/api.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart	View	7 chunks	+10 lines, -12 lines	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/edit/refactoring_test.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/generated/java/types/ExtractLocalVariableFeedback.java	View	2 chunks	+14 lines, -10 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 1 month ago (2015-11-03 18:19:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
069ba985de7e6e1c83d07c539a56935f05924889 (presubmit successful).