pkg/analysis_server/lib/src/edit/edit_domain.dart - Issue 1407333006: Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/edit/edit_domain.dart

Issue 1407333006: Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart ('k') | pkg/analysis_server/test/edit/refactoring_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/edit/edit_domain.dart

diff --git a/pkg/analysis_server/lib/src/edit/edit_domain.dart b/pkg/analysis_server/lib/src/edit/edit_domain.dart

index 3931907a24abe43aea1a7ef9c7d72933669de228..4b0862de6a7e1faf637245f609e9b512ef846117 100644

--- a/pkg/analysis_server/lib/src/edit/edit_domain.dart

+++ b/pkg/analysis_server/lib/src/edit/edit_domain.dart

@@ -558,7 +558,9 @@ class _RefactoringManager {

if (units.isNotEmpty) {

refactoring = new ExtractLocalRefactoring(units[0], offset, length);

feedback = new ExtractLocalVariableFeedback(

- <int>[], <int>[], <String>[], <int>[], <int>[]);

+ <String>[], <int>[], <int>[],

+ coveringExpressionOffsets: <int>[],

+ coveringExpressionLengths: <int>[]);

}

if (kind == RefactoringKind.EXTRACT_METHOD) {