Issue 140733002: Revert 244982 "Revert 244857 "net: Remove classes which were use..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140733002: Revert 244982 "Revert 244857 "net: Remove classes which were use..." (Closed)

Created:
6 years, 11 months ago by hashimoto

Modified:
6 years, 11 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 244982 "Revert 244857 "net: Remove classes which were use..." > Revert 244857 "net: Remove classes which were used only by Chrom..." > > > net: Remove classes which were used only by Chrome Frame > > > > UploadData and UploadFileElementReaderSync were used only by Chrome Frame > > > > BUG=None > > TEST=build > > R=mmenke@chromium.org > > TBR=jam@chromium.org for content/child/resource_dispatcher_unittests.cc > > > > Review URL: https://codereview.chromium.org/131903004 > > TBR=hashimoto@chromium.org > > Review URL: https://codereview.chromium.org/139263007 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245476

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -335 lines)			Patch
M	content/child/resource_dispatcher_unittest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
D	net/base/upload_data.h	View	1	1 chunk	+0 lines, -83 lines	0 comments	Download
D	net/base/upload_data.cc	View	1	1 chunk	+0 lines, -37 lines	0 comments	Download
M	net/base/upload_file_element_reader.h	View	1	1 chunk	+0 lines, -31 lines	0 comments	Download
M	net/base/upload_file_element_reader.cc	View	1	1 chunk	+0 lines, -48 lines	0 comments	Download
M	net/base/upload_file_element_reader_unittest.cc	View	1	1 chunk	+0 lines, -133 lines	0 comments	Download
M	net/net.gyp	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

hashimoto

Will land this after the failing tests are disabled on TSAN (https://codereview.chromium.org/139543006/)

6 years, 11 months ago (2014-01-16 09:53:19 UTC) #2

hashimoto

6 years, 11 months ago (2014-01-17 10:06:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r245476 (presubmit successful).