Issue 131903004: net: Remove classes which were used only by Chrome Frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131903004: net: Remove classes which were used only by Chrome Frame (Closed)

Created:
6 years, 11 months ago by hashimoto

Modified:
6 years, 11 months ago

Reviewers:
jam, mmenke

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

net: Remove classes which were used only by Chrome Frame UploadData and UploadFileElementReaderSync were used only by Chrome Frame BUG=None TEST=build R=mmenke@chromium.org TBR=jam@chromium.org for content/child/resource_dispatcher_unittests.cc Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244857

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -335 lines)			Patch
M	content/child/resource_dispatcher_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	net/base/upload_data.h	View	1 chunk	+0 lines, -83 lines	0 comments	Download
D	net/base/upload_data.cc	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	net/base/upload_file_element_reader.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	net/base/upload_file_element_reader.cc	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	net/base/upload_file_element_reader_unittest.cc	View	1 chunk	+0 lines, -133 lines	0 comments	Download
M	net/net.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

hashimoto

TBRing jam@chromium.org for the removal of upload_data.h include in resource_dispatcher_unittests.cc.

6 years, 11 months ago (2014-01-15 07:30:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/131903004/1

6 years, 11 months ago (2014-01-15 08:26:11 UTC) #4

hashimoto

6 years, 11 months ago (2014-01-15 09:54:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r244857 (presubmit successful).