next step toward completion plugin API

next step toward completion plugin API
- revised the new completion contributor API
- moving contributors into new subfolder when they follow the new API
- updated InheritedContributor to use the new API
- partially implemented ReferenceContributor
- modified CompletionTarget to have a compilation unit accessor

ReferenceContributor will eventually replace both LocalReferenceContributor and ImportedReferenceContributor. I only implemented enough of it to convince myself that the new API is sound. I will finish it in a subsequent CL.

[danrubel, 2015-10-19 21:38:08]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-10-19 23:15:46]

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart
(right):

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart:19: * An
object used to produce completions within a Dart file.
"completions within" --> "completions at a specific location within"

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart:20: *
Contributors are long-lived objects and must not retain any state.
I think with the introduction of futures, they're not just long-lived, they are
required to be re-entrant (in which case we should say so).

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart:52:
@deprecated // Use parsedTarget.unit or resolvedTarget(...).unit
"resolvedTarget(...)" --> "resolvedDeclarationTarget"

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/completion_dart.dart
(right):

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/completion_dart.dart:46:
Future<CompletionTarget> get resolvedDeclarationTarget {
Consider making this an async function body.

[danrubel, 2015-10-20 00:11:17]

Comments addressed. PTAL

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart
(right):

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart:19: * An
object used to produce completions within a Dart file.
On 2015/10/19 23:15:46, Brian Wilkerson wrote:
> "completions within" --> "completions at a specific location within"

Done.

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart:20: *
Contributors are long-lived objects and must not retain any state.
On 2015/10/19 23:15:46, Brian Wilkerson wrote:
> I think with the introduction of futures, they're not just long-lived, they
are
> required to be re-entrant (in which case we should say so).

Done.

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart:52:
@deprecated // Use parsedTarget.unit or resolvedTarget(...).unit
On 2015/10/19 23:15:46, Brian Wilkerson wrote:
> "resolvedTarget(...)" --> "resolvedDeclarationTarget"

Done.

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/completion_dart.dart
(right):

https://codereview.chromium.org/1407273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/completion_dart.dart:46:
Future<CompletionTarget> get resolvedDeclarationTarget {
On 2015/10/19 23:15:46, Brian Wilkerson wrote:
> Consider making this an async function body.

Good idea. It's now easier to read.

[danrubel, 2015-11-22 02:21:09]

Description was changed from

==========
next step toward completion plugin API
- revised the new completion contributor API
- moving contributors into new subfolder when they follow the new API
- updated InheritedContributor to use the new API
- partially implemented ReferenceContributor
- modified CompletionTarget to have a compilation unit accessor

ReferenceContributor will eventually replace both LocalReferenceContributor and
ImportedReferenceContributor. I only implemented enough of it to convince myself
that the new API is sound. I will finish it in a subsequent CL.
==========

to

==========
next step toward completion plugin API
- revised the new completion contributor API
- moving contributors into new subfolder when they follow the new API
- updated InheritedContributor to use the new API
- partially implemented ReferenceContributor
- modified CompletionTarget to have a compilation unit accessor

ReferenceContributor will eventually replace both LocalReferenceContributor and
ImportedReferenceContributor. I only implemented enough of it to convince myself
that the new API is sound. I will finish it in a subsequent CL.
==========