pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart - Issue 1407273004: next step toward completion plugin API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart

Issue 1407273004: next step toward completion plugin API (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart ('k') | pkg/analysis_server/lib/src/services/completion/completion_core.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart b/pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart

index e3c44ce487ea660195f174cf80d6ff6ee8020fe6..0eb335473c68e337bb65aa4c3bbaf99c19155f28 100644

--- a/pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart

+++ b/pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart

@@ -45,8 +45,8 @@ class CommonUsageComputer implements ContributionSorter {

void _update(DartCompletionRequest request,

Iterable<CompletionSuggestion> suggestions) {

- var visitor = new _BestTypeVisitor(request.target.entity);

- DartType type = request.target.containingNode.accept(visitor);

+ var visitor = new _BestTypeVisitor(request.parsedTarget.entity);

+ DartType type = request.parsedTarget.containingNode.accept(visitor);

if (type != null) {

Element typeElem = type.element;

if (typeElem != null) {