Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1407263005: Subzero: Fix MINIMAL build issues. (Closed)

Created:
5 years, 2 months ago by Jim Stichnoth
Modified:
5 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Missed one file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/IceAssemblerARM32.cpp View 3 chunks +7 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/add.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/load-store.ll View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/mov-imm.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/sub.ll View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jim Stichnoth
5 years, 2 months ago (2015-10-16 20:27:33 UTC) #2
Karl
lgtm
5 years, 2 months ago (2015-10-16 20:31:02 UTC) #4
Karl
still lgtm.
5 years, 2 months ago (2015-10-16 20:32:24 UTC) #5
Jim Stichnoth
5 years, 2 months ago (2015-10-16 20:34:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
659cc4f2ec50d541c281589d3af8403b5281e58c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698