Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1407143003:
Oilpan: Add more static/runtime ASSERTs about ShouldBeTraced (Closed)
|
Created:
5 years, 2 months ago by haraken Modified:
5 years, 2 months ago CC:
chromium-reviews, haraken, oilpan-reviews, blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOilpan: Add more static/runtime ASSERTs about ShouldBeTraced
BUG=475801
Committed: https://crrev.com/8f7bf086d05478d3c8943975ec28a9d665f47f47
Cr-Commit-Position: refs/heads/master@{#354726}
Patch Set 1 #Patch Set 2 : #
Total comments: 1
Messages
Total messages: 22 (10 generated)
haraken@chromium.org changed reviewers: + keishi@chromium.org
PTAL
LGTM
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407143003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by haraken@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org Link to the patchset: https://codereview.chromium.org/1407143003/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407143003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407143003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407143003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8f7bf086d05478d3c8943975ec28a9d665f47f47 Cr-Commit-Position: refs/heads/master@{#354726}
Message was sent while issue was closed.
sigbjornf@opera.com changed reviewers: + sigbjornf@opera.com
Message was sent while issue was closed.
https://codereview.chromium.org/1407143003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/heap/TraceTraits.h (right): https://codereview.chromium.org/1407143003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/heap/TraceTraits.h:183: static_assert(WTF::NeedsTracing<T>::value || WTF::IsWeak<T>::value, "T should be traced"); What is this assert for (in this context)? NeedsTracing<> checks if you have trace() method, and we most certainly will have one here. ? |
