Source/core/platform/network/SocketStreamErrorBase.h - Issue 14071008: WebSocket object should fire error event when WebSocket server can't be connected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/network/SocketStreamErrorBase.h

Issue 14071008: WebSocket object should fire error event when WebSocket server can't be connected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Add new layouttests into TestExceptions because it depends on chromium side patch Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/chromium/support/WebSocketStreamError.cpp ('k') | Source/core/platform/network/SocketStreamErrorBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/network/SocketStreamErrorBase.h

diff --git a/Source/core/platform/network/SocketStreamErrorBase.h b/Source/core/platform/network/SocketStreamErrorBase.h

index 132063f2b2a73f95eaf457e76f89fbfd6bf328a7..232625bfc0a6340703e45feb10b7bd0f86e0ee53 100644

--- a/Source/core/platform/network/SocketStreamErrorBase.h

+++ b/Source/core/platform/network/SocketStreamErrorBase.h

@@ -40,8 +40,6 @@ namespace WebCore {

class SocketStreamErrorBase {

public:

- // Makes a deep copy. Useful for when you need to use a SocketStreamError on another thread.

- SocketStreamError copy() const;

bool isNull() const { return m_isNull; }