Source/core/platform/network/SocketStreamErrorBase.cpp - Issue 14071008: WebSocket object should fire error event when WebSocket server can't be connected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/network/SocketStreamErrorBase.cpp

Issue 14071008: WebSocket object should fire error event when WebSocket server can't be connected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Add new layouttests into TestExceptions because it depends on chromium side patch Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/network/SocketStreamErrorBase.h ('k') | Source/core/platform/network/chromium/SocketStreamError.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/network/SocketStreamErrorBase.cpp

diff --git a/Source/core/platform/network/SocketStreamErrorBase.cpp b/Source/core/platform/network/SocketStreamErrorBase.cpp

index bbb5d553f5b000cd4d53d501a598dedf28d39fcd..c013a4652c7d87421bce32b0617f447f1dece4e1 100644

--- a/Source/core/platform/network/SocketStreamErrorBase.cpp

+++ b/Source/core/platform/network/SocketStreamErrorBase.cpp

@@ -33,13 +33,6 @@

namespace WebCore {

-SocketStreamError SocketStreamErrorBase::copy() const

- SocketStreamError errorCopy;

- errorCopy.m_errorCode = m_errorCode;

- return errorCopy;

bool SocketStreamErrorBase::compare(const SocketStreamError& a, const SocketStreamError& b)

{

if (a.isNull() && b.isNull())

« no previous file with comments | « Source/core/platform/network/SocketStreamErrorBase.h ('k') | Source/core/platform/network/chromium/SocketStreamError.h » ('j') | no next file with comments »