Issue 1407063012: Merge to XFA: Keep "static" objects per-context rather than per isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1407063012: Merge to XFA: Keep "static" objects per-context rather than per isolate. (Closed)

Created:
5 years, 1 month ago by Tom Sepez

Modified:
5 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Keep "static" objects per-context rather than per isolate. Original Review URL: https://codereview.chromium.org/1424933013 . (cherry picked from commit 7d4c74d1b96d82681d49519c129262a1568e87d4) TBR=jochen@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4237aedc2efb0e7a8479148592af349addf86a89

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -28 lines)			Patch
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	6 chunks	+24 lines, -19 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Tom Sepez

5 years, 1 month ago (2015-11-10 23:19:20 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4237aedc2efb0e7a8479148592af349addf86a89 (presubmit successful).