fpdfsdk/src/javascript/JS_Runtime.cpp - Issue 1407063012: Merge to XFA: Keep "static" objects per-context rather than per isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Runtime.cpp

Issue 1407063012: Merge to XFA: Keep "static" objects per-context rather than per isolate. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/javascript/JS_Runtime.cpp

diff --git a/fpdfsdk/src/javascript/JS_Runtime.cpp b/fpdfsdk/src/javascript/JS_Runtime.cpp

index ecb53d2d724fe8e6a5d767d5e89f70b83a57d431..3e1f74beed390a09e4a8e54ddd9d5914d01448c9 100644

--- a/fpdfsdk/src/javascript/JS_Runtime.cpp

+++ b/fpdfsdk/src/javascript/JS_Runtime.cpp

@@ -77,7 +77,7 @@ CJS_Runtime::CJS_Runtime(CPDFDoc_Environment* pApp)

v8::HandleScope handle_scope(isolate);

if (CPDFXFA_App::GetInstance()->IsJavaScriptInitialized()) {

CJS_Context* pContext = (CJS_Context*)NewContext();

- FXJS_InitializeRuntime(GetIsolate(), this, m_context);

+ FXJS_InitializeRuntime(GetIsolate(), this, &m_context, &m_StaticObjects);

ReleaseContext(pContext);

return;

}

@@ -88,7 +88,7 @@ CJS_Runtime::CJS_Runtime(CPDFDoc_Environment* pApp)

CPDFXFA_App::GetInstance()->SetJavaScriptInitialized(TRUE);

CJS_Context* pContext = (CJS_Context*)NewContext();

- FXJS_InitializeRuntime(GetIsolate(), this, m_context);

+ FXJS_InitializeRuntime(GetIsolate(), this, &m_context, &m_StaticObjects);

ReleaseContext(pContext);

}

« no previous file with comments | « fpdfsdk/src/javascript/JS_Runtime.h ('k') | fpdfsdk/src/jsapi/fxjs_v8.cpp » ('j') | no next file with comments »