Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1407053009: Simplify linkages to Android framework internals (Closed)

Created:
5 years, 2 months ago by tomhudson
Modified:
5 years, 1 month ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify linkages to Android framework internals We've migrated SkHwuiRenderer into the Android Framework as android::uirenderer::TestWindowContext in response to an internal bug; we now delete that class and change our build references here. R=djsollen@google.com Committed: https://skia.googlesource.com/skia/+/3c8ceb7350327ce5a2fdfd10e5e5469b9ee8169b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix djsollen nit #

Patch Set 3 : One gyp file is much like another #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -192 lines) Patch
M bench/nanobenchAndroid.h View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/nanobenchAndroid.cpp View 3 chunks +3 lines, -10 lines 0 comments Download
M dm/DMSrcSinkAndroid.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/dm.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/utils.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D src/utils/android/SkHwuiRenderer.h View 1 chunk +0 lines, -42 lines 0 comments Download
D src/utils/android/SkHwuiRenderer.cpp View 1 chunk +0 lines, -128 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
tomhudson
The critical lines for review are the removals from the gyp files. :)
5 years, 2 months ago (2015-10-23 14:37:06 UTC) #1
tomhudson
These changes rolled into master-skia on Friday, so should be safe to land now.
5 years, 1 month ago (2015-10-26 12:15:06 UTC) #2
djsollen
lgtm with one nit. https://codereview.chromium.org/1407053009/diff/1/dm/DMSrcSinkAndroid.cpp File dm/DMSrcSinkAndroid.cpp (right): https://codereview.chromium.org/1407053009/diff/1/dm/DMSrcSinkAndroid.cpp#newcode22 dm/DMSrcSinkAndroid.cpp:22: //SkHwuiRenderer renderer; remove this line.
5 years, 1 month ago (2015-10-26 13:28:15 UTC) #3
tomhudson
Oops. https://codereview.chromium.org/1407053009/diff/1/dm/DMSrcSinkAndroid.cpp File dm/DMSrcSinkAndroid.cpp (right): https://codereview.chromium.org/1407053009/diff/1/dm/DMSrcSinkAndroid.cpp#newcode22 dm/DMSrcSinkAndroid.cpp:22: //SkHwuiRenderer renderer; On 2015/10/26 13:28:15, djsollen wrote: > ...
5 years, 1 month ago (2015-10-26 14:00:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407053009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407053009/20001
5 years, 1 month ago (2015-10-26 14:01:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/3932)
5 years, 1 month ago (2015-10-26 14:03:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407053009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407053009/40001
5 years, 1 month ago (2015-10-26 14:10:24 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 14:21:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3c8ceb7350327ce5a2fdfd10e5e5469b9ee8169b

Powered by Google App Engine
This is Rietveld 408576698