Issue 1407043008: Revert of Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1407043008: Revert of Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader (Closed)

Created:
5 years, 2 months ago by caryclark

Modified:
5 years, 2 months ago

Reviewers:
f(malita), reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader (patchset #3 id:40001 of https://codereview.chromium.org/1405103003/ ) Reason for revert: Test to see if patch fixes Nexus 6. Original issue's description: > Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader > > Use an SkImage generator/shader instead. > > R=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/fa694ad067976a5b713eec0b6f92ba5efeb0aa9d TBR=reed@google.com,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/b4a20767ee129ba47cee42e61252a9faec09c3a6

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -18 lines)			Patch
	M	src/core/SkPictureShader.cpp	View		2 chunks	+7 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

caryclark

Created Revert of Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader

5 years, 2 months ago (2015-10-21 17:51:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407043008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407043008/1

5 years, 2 months ago (2015-10-21 18:38:59 UTC) #3

commit-bot: I haz the power

5 years, 2 months ago (2015-10-21 18:39:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b4a20767ee129ba47cee42e61252a9faec09c3a6

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages