Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1407003016: Reland of path ops: fix conic weight and partial coincidence (Closed)

Created:
5 years, 2 months ago by caryclark
Modified:
5 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of path ops: fix conic weight and partial coincidence (patchset #1 id:1 of https://codereview.chromium.org/1408923003/ ) Reason for revert: suppressions have landed in chrome Original issue's description: > Revert of path ops: fix conic weight and partial coincidence (patchset #5 id:80001 of https://codereview.chromium.org/1413763002/ ) > > Reason for revert: > path ops change breaks svg clipping layout tests -- conic is now more accurate, changing edge of circle in clip > > These need to be rebaselined > > svg/clip-path/clip-path-child-clipped.svg > svg/clip-path/clip-path-nonzero.svg > svg/clip-path/clip-path-evenodd-nonzero.svg > svg/clip-path/clip-path-nonzero-evenodd.svg > > Original issue's description: > > The remaining 1m skp bugs are asserts that can be harmlessly > > suppressed and bugs around conics. > > > > The conic calculation for a subdivided w was just wrong. > > > > Also added debugging to template intersection to initialize > > reused structures and dump additional data. > > > > TBR=reed@google.com > > > > Committed: https://skia.googlesource.com/skia/+/ef33b1e739b23a1201100ff17a572da85b03d9af > > TBR= > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/f428df1be3e96d3f8970d0f7f415b862f7da5404 TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/ed0935a28a29af7d3b16ac8d9365f291a335c6bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+824 lines, -129 lines) Patch
M src/pathops/SkOpCoincidence.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsConic.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsConic.cpp View 2 chunks +28 lines, -6 lines 0 comments Download
M src/pathops/SkPathOpsCubic.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsQuad.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsRect.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 9 chunks +61 lines, -11 lines 0 comments Download
M src/pathops/SkPathOpsWinding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSkpTest.cpp View 2 chunks +661 lines, -3 lines 0 comments Download
M tests/PathOpsTSectDebug.h View 2 chunks +16 lines, -6 lines 0 comments Download
M tools/pathops_sorter.htm View 1 chunk +19 lines, -4 lines 0 comments Download
M tools/pathops_visualizer.htm View 11 chunks +21 lines, -89 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caryclark
Created Reland of path ops: fix conic weight and partial coincidence
5 years, 2 months ago (2015-10-22 14:23:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407003016/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407003016/1
5 years, 2 months ago (2015-10-22 14:23:45 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 14:23:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ed0935a28a29af7d3b16ac8d9365f291a335c6bd

Powered by Google App Engine
This is Rietveld 408576698