Issue 14070005: Run style checks also when uploading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14070005: Run style checks also when uploading. (Closed)

Created:
7 years, 8 months ago by marja

Modified:
7 years, 8 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Run style checks also when uploading. The right moment for fixing style errors is when working on the CL, not when committing it. And this makes non-committers bump into this check too when uploading changes. BUG=none Committed: http://code.google.com/p/v8/source/detail?r=14231

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	PRESUBMIT.py	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

7 years, 8 months ago (2013-04-11 12:41:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14231 (presubmit successful).

Expand Messages | Collapse Messages