| OLD | NEW |
| 1 # Copyright 2012 the V8 project authors. All rights reserved. | 1 # Copyright 2012 the V8 project authors. All rights reserved. |
| 2 # Redistribution and use in source and binary forms, with or without | 2 # Redistribution and use in source and binary forms, with or without |
| 3 # modification, are permitted provided that the following conditions are | 3 # modification, are permitted provided that the following conditions are |
| 4 # met: | 4 # met: |
| 5 # | 5 # |
| 6 # * Redistributions of source code must retain the above copyright | 6 # * Redistributions of source code must retain the above copyright |
| 7 # notice, this list of conditions and the following disclaimer. | 7 # notice, this list of conditions and the following disclaimer. |
| 8 # * Redistributions in binary form must reproduce the above | 8 # * Redistributions in binary form must reproduce the above |
| 9 # copyright notice, this list of conditions and the following | 9 # copyright notice, this list of conditions and the following |
| 10 # disclaimer in the documentation and/or other materials provided | 10 # disclaimer in the documentation and/or other materials provided |
| (...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 46 results.append(output_api.PresubmitError( | 46 results.append(output_api.PresubmitError( |
| 47 "Copyright header and trailing whitespaces check failed")) | 47 "Copyright header and trailing whitespaces check failed")) |
| 48 return results | 48 return results |
| 49 | 49 |
| 50 | 50 |
| 51 def _CommonChecks(input_api, output_api): | 51 def _CommonChecks(input_api, output_api): |
| 52 """Checks common to both upload and commit.""" | 52 """Checks common to both upload and commit.""" |
| 53 results = [] | 53 results = [] |
| 54 results.extend(input_api.canned_checks.CheckOwners( | 54 results.extend(input_api.canned_checks.CheckOwners( |
| 55 input_api, output_api, source_file_filter=None)) | 55 input_api, output_api, source_file_filter=None)) |
| 56 results.extend(_V8PresubmitChecks(input_api, output_api)) |
| 56 return results | 57 return results |
| 57 | 58 |
| 58 | 59 |
| 59 def CheckChangeOnUpload(input_api, output_api): | 60 def CheckChangeOnUpload(input_api, output_api): |
| 60 results = [] | 61 results = [] |
| 61 results.extend(_CommonChecks(input_api, output_api)) | 62 results.extend(_CommonChecks(input_api, output_api)) |
| 62 return results | 63 return results |
| 63 | 64 |
| 64 | 65 |
| 65 def CheckChangeOnCommit(input_api, output_api): | 66 def CheckChangeOnCommit(input_api, output_api): |
| 66 results = [] | 67 results = [] |
| 67 results.extend(_CommonChecks(input_api, output_api)) | 68 results.extend(_CommonChecks(input_api, output_api)) |
| 68 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 69 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 69 input_api, output_api)) | 70 input_api, output_api)) |
| 70 results.extend(_V8PresubmitChecks(input_api, output_api)) | |
| 71 return results | 71 return results |
| OLD | NEW |