Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 1406993008: win: Rename CrashpadClient::SetHandler() to SetHandlerIPCPipe() (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Rename CrashpadClient::SetHandler() to SetHandlerIPCPipe() In https://codereview.chromium.org/1414533006/, I'm adding a few Mac-specific SetHandler() variants, so it makes sense to name each SetHandler() variant for what it does. I'm also making it take a wstring argument, which seems like a more natural fit for what it does. There should be fewer string conversions this way. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7f939285dea16391721f79a446311b8830e43acd

Patch Set 1 #

Patch Set 2 : Self-review #

Patch Set 3 : Argument and member too #

Total comments: 1

Patch Set 4 : Revise comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -47 lines) Patch
M client/crashpad_client.h View 1 2 3 4 chunks +5 lines, -7 lines 0 comments Download
M client/crashpad_client_win.cc View 1 2 5 chunks +12 lines, -13 lines 0 comments Download
M handler/handler.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
M handler/win/crashy_test_program.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M handler/win/crashy_test_z7_loader.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M handler/win/self_destroying_test_program.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M snapshot/win/crashpad_snapshot_test_crashing_child.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download
M snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M util/win/exception_handler_server_test.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
5 years, 1 month ago (2015-11-02 20:00:21 UTC) #2
scottmg
lgtm
5 years, 1 month ago (2015-11-02 20:23:53 UTC) #3
Mark Mentovai
Updated to rename the ipc_port argument and member to ipc_pipe.
5 years, 1 month ago (2015-11-02 21:44:48 UTC) #4
scottmg
lgtm https://codereview.chromium.org/1406993008/diff/40001/client/crashpad_client.h File client/crashpad_client.h (right): https://codereview.chromium.org/1406993008/diff/40001/client/crashpad_client.h#newcode85 client/crashpad_client.h:85: //! \param[in] ipc_pipe The full name of the ...
5 years, 1 month ago (2015-11-02 21:49:57 UTC) #5
Mark Mentovai
5 years, 1 month ago (2015-11-02 22:00:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
7f939285dea16391721f79a446311b8830e43acd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698