Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Unified Diff: util/win/exception_handler_server_test.cc

Issue 1406993008: win: Rename CrashpadClient::SetHandler() to SetHandlerIPCPipe() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Revise comment Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/exception_handler_server_test.cc
diff --git a/util/win/exception_handler_server_test.cc b/util/win/exception_handler_server_test.cc
index c1e5d7f4bcaf5128f713a5669ba2ad56272804af..8cfbb45f3d92be0f20e4a33ba820dd35dc1135d5 100644
--- a/util/win/exception_handler_server_test.cc
+++ b/util/win/exception_handler_server_test.cc
@@ -21,6 +21,7 @@
#include "base/basictypes.h"
#include "base/strings/stringprintf.h"
+#include "base/strings/utf_string_conversions.h"
#include "client/crashpad_client.h"
#include "gtest/gtest.h"
#include "test/win/win_child_process.h"
@@ -134,7 +135,7 @@ TEST_F(ExceptionHandlerServerTest, StopWhileConnected) {
&server(), &server_thread());
ASSERT_NO_FATAL_FAILURE(delegate().WaitForStart());
CrashpadClient client;
- client.SetHandler(pipe_name()); // Connect to server.
+ client.SetHandlerIPCPipe(base::UTF8ToUTF16(pipe_name()));
// Leaving this scope causes the server to be stopped, while the connection
// is still open.
}
@@ -161,9 +162,9 @@ class TestClient final : public WinChildProcess {
private:
int Run() override {
- std::string pipe_name = ReadString(ReadPipeHandle());
+ std::wstring pipe_name = base::UTF8ToUTF16(ReadString(ReadPipeHandle()));
CrashpadClient client;
- if (!client.SetHandler(pipe_name)) {
+ if (!client.SetHandlerIPCPipe(pipe_name)) {
ADD_FAILURE();
return EXIT_FAILURE;
}
« no previous file with comments | « snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698