third_party/WebKit/Source/core/layout/LayoutBlockFlow.h - Issue 1406973008: Calculate minimum column height after layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 1406973008: Calculate minimum column height after layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

index d995052037b8d3f2cda3fdcbe0fdef25d19328fc..cb05410917234bff2c63973dbaba79c4e1321044 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

@@ -530,7 +530,7 @@ private:

// Computes a deltaOffset value that put a line at the top of the next page if it doesn't fit on the current page.

void adjustLinePositionForPagination(RootInlineBox&, LayoutUnit& deltaOffset);

// If the child is unsplittable and can't fit on the current page, return the top of the next page/column.

- LayoutUnit adjustForUnsplittableChild(LayoutBox&, LayoutUnit logicalOffset);

+ LayoutUnit adjustForUnsplittableChild(LayoutBox&, LayoutUnit logicalOffset) const;

// Used to store state between styleWillChange and styleDidChange

static bool s_canPropagateFloatIntoSibling;