third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 1406973008: Calculate minimum column height after layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 1406973008: Calculate minimum column height after layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index 272eef08d877bcfad0d5838c6bf47a33de0c1f11..9fb9ed8dde5f69085efa2a976563fee2b42cb63c 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -2650,12 +2650,6 @@ void LayoutBlock::paginatedContentWasLaidOut(LayoutUnit logicalTopOffsetAfterPag

flowThread->contentWasLaidOut(offsetFromLogicalTopOfFirstPage() + logicalTopOffsetAfterPagination);

}

-void LayoutBlock::updateMinimumPageHeight(LayoutUnit offset, LayoutUnit minHeight)

- if (LayoutFlowThread* flowThread = flowThreadContainingBlock())

- flowThread->updateMinimumPageHeight(offsetFromLogicalTopOfFirstPage() + offset, minHeight);

LayoutUnit LayoutBlock::collapsedMarginBeforeForChild(const LayoutBox& child) const

{

// If the child has the same directionality as we do, then we can just return its