Issue 1406933007: Merge to XFA: Use unique_ptr and initializer lists in various render files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1406933007: Merge to XFA: Use unique_ptr and initializer lists in various render files. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
dsinclair

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Use unique_ptr and initializer lists in various render files. TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1436573003 . (cherry picked from commit c813e21d261c24867234107f2e2ca72e15cb2534) Committed: https://pdfium.googlesource.com/pdfium/+/5044cab9c228ecd39e0ba07f0f5cced0a1cf6dd4

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+192 lines, -200 lines)			Patch
M	core/include/fpdfapi/fpdf_pageobj.h	View	2 chunks	+15 lines, -13 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render.cpp	View	15 chunks	+124 lines, -138 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp	View	7 chunks	+37 lines, -40 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_render/render_int.h	View	8 chunks	+16 lines, -9 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 1 month ago (2015-11-10 18:09:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5044cab9c228ecd39e0ba07f0f5cced0a1cf6dd4 (presubmit successful).