Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1436573003: Use unique_ptr and initializer lists in various render files. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use unique_ptr and initializer lists in various render files. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c813e21d261c24867234107f2e2ca72e15cb2534

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -200 lines) Patch
M core/include/fpdfapi/fpdf_pageobj.h View 2 chunks +15 lines, -13 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 1 15 chunks +124 lines, -138 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 7 chunks +37 lines, -40 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 8 chunks +16 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
5 years, 1 month ago (2015-11-10 09:18:19 UTC) #3
dsinclair
lgtm
5 years, 1 month ago (2015-11-10 17:47:49 UTC) #4
Lei Zhang
5 years, 1 month ago (2015-11-10 18:07:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
c813e21d261c24867234107f2e2ca72e15cb2534 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698