Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1406923005: Fix documentation for ObjectProxy::ConnectToSignal() (Closed)

Created:
5 years, 2 months ago by mukesh agrawal
Modified:
5 years, 2 months ago
Reviewers:
hashimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix documentation for ObjectProxy::ConnectToSignal() The documentation for ObjectProxy::ConnectToSignal() differs from the method's actual behavior. Fix this, by updating the documentation. BUG=545139 R=hashimoto@chromium.org TEST=compile Committed: https://crrev.com/b270236865580fbedf0eb24d6610a2051b6200a3 Cr-Commit-Position: refs/heads/master@{#355785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M dbus/object_proxy.h View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
mukesh agrawal
5 years, 2 months ago (2015-10-22 21:11:58 UTC) #1
mukesh agrawal
PTAL. Thanks.
5 years, 2 months ago (2015-10-22 21:12:33 UTC) #2
hashimoto
lgtm Thanks!
5 years, 2 months ago (2015-10-23 04:18:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406923005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406923005/1
5 years, 2 months ago (2015-10-23 14:32:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 15:06:16 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 15:07:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b270236865580fbedf0eb24d6610a2051b6200a3
Cr-Commit-Position: refs/heads/master@{#355785}

Powered by Google App Engine
This is Rietveld 408576698