Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2439)

Unified Diff: dbus/object_proxy.h

Issue 1406923005: Fix documentation for ObjectProxy::ConnectToSignal() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/object_proxy.h
diff --git a/dbus/object_proxy.h b/dbus/object_proxy.h
index c0211b1db6187f975b9ef2c347366d69d47633c2..9f32821d6b8f398ed7df1cfce4580f7a0f925094 100644
--- a/dbus/object_proxy.h
+++ b/dbus/object_proxy.h
@@ -146,8 +146,7 @@ class CHROME_DBUS_EXPORT ObjectProxy
ResponseCallback callback,
ErrorCallback error_callback);
- // Requests to connect to the signal from the remote object, replacing
- // any previous |signal_callback| connected to that signal.
+ // Requests to connect to the signal from the remote object.
//
// |signal_callback| will be called in the origin thread, when the
// signal is received from the remote object. As it's called in the
@@ -157,6 +156,11 @@ class CHROME_DBUS_EXPORT ObjectProxy
// |on_connected_callback| is called when the object proxy is connected
// to the signal, or failed to be connected, in the origin thread.
//
+ // If a SignalCallback has already been registered for the given
+ // |interface_name| and |signal_name|, |signal_callback| will be
+ // added to the list of callbacks for |interface_name| and
+ // |signal_name|.
+ //
// Must be called in the origin thread.
virtual void ConnectToSignal(const std::string& interface_name,
const std::string& signal_name,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698