Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 14069005: Introduce the API OWNERS (Closed)

Created:
7 years, 8 months ago by abarth-chromium
Modified:
7 years, 8 months ago
Reviewers:
ojan
CC:
blink-reviews
Visibility:
Public.

Description

Introduce the API OWNERS See http://www.chromium.org/blink/#TOC-API-Owners for a description of the role these folks play. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148119

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
A Source/OWNERS View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ojan
Maybe add *.in files as well to cover things like CSS property names?
7 years, 8 months ago (2013-04-10 21:41:17 UTC) #1
abarth-chromium
Yeah, there's a FIXME about that. The problem is that not every "in" file controls ...
7 years, 8 months ago (2013-04-10 21:48:12 UTC) #2
ojan
lgtm On 2013/04/10 21:48:12, abarth wrote: > Yeah, there's a FIXME about that. The problem ...
7 years, 8 months ago (2013-04-10 22:29:22 UTC) #3
abarth-chromium
Committed patchset #2 manually as r148119 (presubmit successful).
7 years, 8 months ago (2013-04-10 23:00:17 UTC) #4
abarth-chromium
7 years, 8 months ago (2013-04-10 23:01:52 UTC) #5
Message was sent while issue was closed.
> Other than Settings.in, I don't see any.  Doesn't seem like the end of the
world
> to me if, in the short term, Settings.in changes need API owners review. We
> don't add/remove settings that often, do we?

Done.

Powered by Google App Engine
This is Rietveld 408576698