src/lithium-codegen.cc - Issue 140683011: Improve positions tracking inside the HGraphBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lithium-codegen.cc

Issue 140683011: Improve positions tracking inside the HGraphBuilder. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/lithium-codegen.cc

diff --git a/src/lithium-codegen.cc b/src/lithium-codegen.cc

index 2d71d13c69fd9536203e99f40b88dee006b85bc0..a057c2fd88829a545363d5256972d564df6b3de3 100644

--- a/src/lithium-codegen.cc

+++ b/src/lithium-codegen.cc

@@ -104,11 +104,9 @@ bool LCodeGenBase::GenerateBody() {

GenerateBodyInstructionPre(instr);

HValue* value = instr->hydrogen_value();

- if (value->position() != RelocInfo::kNoPosition) {

- ASSERT(!graph()->info()->IsOptimizing() ||

- !FLAG_emit_opt_code_positions ||

- value->position() != RelocInfo::kNoPosition);

- RecordAndWritePosition(value->position());

+ if (!value->position().IsUnknown()) {

+ RecordAndWritePosition(

+ chunk()->graph()->SourcePositionToScriptPosition(value->position()));

}

instr->CompileToNative(codegen);