Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: src/lithium-codegen.cc

Issue 140683011: Improve positions tracking inside the HGraphBuilder. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 if (FLAG_code_comments && instr->HasInterestingComment(codegen)) { 97 if (FLAG_code_comments && instr->HasInterestingComment(codegen)) {
98 Comment(";;; <@%d,#%d> %s", 98 Comment(";;; <@%d,#%d> %s",
99 current_instruction_, 99 current_instruction_,
100 instr->hydrogen_value()->id(), 100 instr->hydrogen_value()->id(),
101 instr->Mnemonic()); 101 instr->Mnemonic());
102 } 102 }
103 103
104 GenerateBodyInstructionPre(instr); 104 GenerateBodyInstructionPre(instr);
105 105
106 HValue* value = instr->hydrogen_value(); 106 HValue* value = instr->hydrogen_value();
107 if (value->position() != RelocInfo::kNoPosition) { 107 if (!value->position().IsUnknown()) {
108 ASSERT(!graph()->info()->IsOptimizing() || 108 RecordAndWritePosition(
109 !FLAG_emit_opt_code_positions || 109 chunk()->graph()->SourcePositionToScriptPosition(value->position()));
110 value->position() != RelocInfo::kNoPosition);
111 RecordAndWritePosition(value->position());
112 } 110 }
113 111
114 instr->CompileToNative(codegen); 112 instr->CompileToNative(codegen);
115 113
116 GenerateBodyInstructionPost(instr); 114 GenerateBodyInstructionPost(instr);
117 } 115 }
118 EnsureSpaceForLazyDeopt(Deoptimizer::patch_size()); 116 EnsureSpaceForLazyDeopt(Deoptimizer::patch_size());
119 last_lazy_deopt_pc_ = masm()->pc_offset(); 117 last_lazy_deopt_pc_ = masm()->pc_offset();
120 return !is_aborted(); 118 return !is_aborted();
121 } 119 }
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 for (int i = 0; i < objects.length(); i++) { 183 for (int i = 0; i < objects.length(); i++) {
186 AddWeakObjectToCodeDependency(isolate()->heap(), objects.at(i), code); 184 AddWeakObjectToCodeDependency(isolate()->heap(), objects.at(i), code);
187 } 185 }
188 for (int i = 0; i < cells.length(); i++) { 186 for (int i = 0; i < cells.length(); i++) {
189 AddWeakObjectToCodeDependency(isolate()->heap(), cells.at(i), code); 187 AddWeakObjectToCodeDependency(isolate()->heap(), cells.at(i), code);
190 } 188 }
191 } 189 }
192 190
193 191
194 } } // namespace v8::internal 192 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698