Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1406743002: Switch cases that returns same value should use fall through. (Closed)

Created:
5 years, 2 months ago by Deepak
Modified:
5 years, 2 months ago
Reviewers:
Bernhard Bauer, lazyboy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Using Fall Through for switch case help in making code cleaner and easy to understandable. BUG=543098 Committed: https://crrev.com/c40535a11b581c7cb6776aa06a51a4d9f03c7060 Cr-Commit-Position: refs/heads/master@{#354244}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes as per review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/android/preferences/pref_service_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/renderer_context_menu/spelling_menu_observer.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Deepak
PTAL
5 years, 2 months ago (2015-10-14 12:41:54 UTC) #2
lazyboy
https://codereview.chromium.org/1406743002/diff/1/components/renderer_context_menu/context_menu_content_type.cc File components/renderer_context_menu/context_menu_content_type.cc (right): https://codereview.chromium.org/1406743002/diff/1/components/renderer_context_menu/context_menu_content_type.cc#newcode146 components/renderer_context_menu/context_menu_content_type.cc:146: case ITEM_GROUP_DEVELOPER: I'd revert changes in this file as ...
5 years, 2 months ago (2015-10-14 15:54:11 UTC) #3
Deepak
PTAL Thanks https://codereview.chromium.org/1406743002/diff/1/components/renderer_context_menu/context_menu_content_type.cc File components/renderer_context_menu/context_menu_content_type.cc (right): https://codereview.chromium.org/1406743002/diff/1/components/renderer_context_menu/context_menu_content_type.cc#newcode146 components/renderer_context_menu/context_menu_content_type.cc:146: case ITEM_GROUP_DEVELOPER: On 2015/10/14 15:54:11, lazyboy wrote: ...
5 years, 2 months ago (2015-10-15 03:55:24 UTC) #4
lazyboy
renderer_context_menu/* LGTM
5 years, 2 months ago (2015-10-15 05:19:30 UTC) #5
Deepak
@Bernhard PTAL for chrome/browser/android/preferences/pref_service_bridge.cc Thanks
5 years, 2 months ago (2015-10-15 08:01:10 UTC) #7
Bernhard Bauer
LGTM, thanks!
5 years, 2 months ago (2015-10-15 08:11:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406743002/20001
5 years, 2 months ago (2015-10-15 08:36:41 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 09:55:57 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 09:56:34 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c40535a11b581c7cb6776aa06a51a4d9f03c7060
Cr-Commit-Position: refs/heads/master@{#354244}

Powered by Google App Engine
This is Rietveld 408576698