chrome/browser/renderer_context_menu/render_view_context_menu.cc - Issue 1406743002: Switch cases that returns same value should use fall through.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 1406743002: Switch cases that returns same value should use fall through. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/preferences/pref_service_bridge.cc ('k') | chrome/browser/renderer_context_menu/spelling_menu_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

index cf6bdd7603d90145e2ae86e68ff6650843cdffad..c865f4b8a5bacead60c86ba0b278d799b5b2eb56 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -1393,14 +1393,8 @@ bool RenderViewContextMenu::IsCommandIdEnabled(int id) const {

#endif

case IDC_SPELLCHECK_MENU:

- return true;

case IDC_CONTENT_CONTEXT_OPENLINKWITH:

- return true;

case IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_SETTINGS:

- return true;

case IDC_CONTENT_CONTEXT_FORCESAVEPASSWORD:

return true;