Source/core/rendering/RenderObject.h - Issue 140673006: Fix repaint on :hover for empty elements with a border.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderObject.h

Issue 140673006: Fix repaint on :hover for empty elements with a border. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/repaint/hover-pseudo-borders-whitespace.html ('K') | « LayoutTests/fast/repaint/hover-pseudo-borders-whitespace-expected.txt ('k') | Source/core/rendering/RenderObject.cpp » ('j') | Source/core/rendering/RenderObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderObject.h

diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h

index c0de169ae7ec0f9b7a3895708c42166f0a5e6e09..cbef860686d420933232e8a66aee85f783b27e31 100644

--- a/Source/core/rendering/RenderObject.h

+++ b/Source/core/rendering/RenderObject.h

@@ -1055,6 +1055,7 @@ private:

void removeFromRenderFlowThreadRecursive(RenderFlowThread*);

bool shouldRepaintForStyleDifference(StyleDifference) const;

+ bool shouldRepaintIfTextOrColorChange() const;

bool hasImmediateNonWhitespaceTextChildOrPropertiesDependentOnColor() const;

RenderStyle* cachedFirstLineStyle() const;