Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 140673006: Fix repaint on :hover for empty elements with a border. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderObject.cpp
diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp
index d1d495c169724088b5fab5544249eceb017216c8..d927b6bc6692df9cbe9c1f679674864286e2c3ce 100644
--- a/Source/core/rendering/RenderObject.cpp
+++ b/Source/core/rendering/RenderObject.cpp
@@ -1900,9 +1900,14 @@ inline bool RenderObject::hasImmediateNonWhitespaceTextChildOrPropertiesDependen
return false;
}
+inline bool RenderObject::shouldRepaintIfTextOrColorChange() const
+{
+ return style()->hasBorder() || hasImmediateNonWhitespaceTextChildOrPropertiesDependentOnColor();
+}
+
inline bool RenderObject::shouldRepaintForStyleDifference(StyleDifference diff) const
{
- return diff == StyleDifferenceRepaint || (diff == StyleDifferenceRepaintIfTextOrColorChange && hasImmediateNonWhitespaceTextChildOrPropertiesDependentOnColor());
+ return diff == StyleDifferenceRepaint || (diff == StyleDifferenceRepaintIfTextOrColorChange && shouldRepaintIfTextOrColorChange());
rune 2014/01/29 19:55:49 This will trigger an unnecessary repaint if you ha
andersr 2014/01/30 09:36:13 Yes, correct. I did not optimize that case becaus
}
void RenderObject::setStyle(PassRefPtr<RenderStyle> style)

Powered by Google App Engine
This is Rietveld 408576698