IDL compiler: Window-specific code + Window-only features

Source/bindings/scripts/unstable/v8_attributes.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 337 matching lines @@
 
 
 ################################################################################
 # Attribute configuration
 ################################################################################
 
 # [Replaceable]
 def setter_callback_name(interface, attribute):
     cpp_class_name = cpp_name(interface)
     extended_attributes = attribute.extended_attributes
-    if ('Replaceable' in extended_attributes or
+    if (('Replaceable' in extended_attributes and
+         'PutForwards' not in extended_attributes) or

[haraken, 2014/02/06 07:57:44]

I don't fully understand this. Is this intended in general? Or is this just for
special-casing Window? (If so, we should simply use interface_name == "Window".)

[Nils Barth (inactive), 2014/02/06 08:40:14]

Yes.
I've placed 'Window' if and only if it's actually Window-specific.

Some general logic only currently occurs in Window,
but should be used generally, so I've made test cases for them.

         is_constructor_attribute(attribute)):
         # FIXME: rename to ForceSetAttributeOnThisCallback, since also used for Constructors
         return '{0}V8Internal::{0}ReplaceableAttributeSetterCallback'.format(cpp_class_name)
     if attribute.is_read_only and 'PutForwards' not in extended_attributes:
         return '0'
     return '%sV8Internal::%sAttributeSetterCallback' % (cpp_class_name, attribute.name)
 
 
 # [DoNotCheckSecurity], [Unforgeable]
 def access_control_list(attribute):
     extended_attributes = attribute.extended_attributes
     access_control = []
     if 'DoNotCheckSecurity' in extended_attributes:
         do_not_check_security = extended_attributes['DoNotCheckSecurity']
         if do_not_check_security == 'Setter':
             access_control.append('v8::ALL_CAN_WRITE')
         else:
             access_control.append('v8::ALL_CAN_READ')
-            if not attribute.is_read_only:
+            if (not attribute.is_read_only or
+                'Replaceable' in extended_attributes):

[haraken, 2014/02/06 07:57:44]

Ditto.

[Nils Barth (inactive), 2014/02/06 08:40:14]

Ditto: this is general.

                 access_control.append('v8::ALL_CAN_WRITE')
     if 'Unforgeable' in extended_attributes:
         access_control.append('v8::PROHIBITS_OVERWRITING')
     return access_control or ['v8::DEFAULT']
 
 
 # [NotEnumerable], [Unforgeable]
 def property_attributes(attribute):
     extended_attributes = attribute.extended_attributes
     property_attributes_list = []
     if ('NotEnumerable' in extended_attributes or
         is_constructor_attribute(attribute)):
         property_attributes_list.append('v8::DontEnum')
     if 'Unforgeable' in extended_attributes:
         property_attributes_list.append('v8::DontDelete')
     return property_attributes_list or ['v8::None']
 
 
 ################################################################################
 # Constructors
 ################################################################################
 
 def is_constructor_attribute(attribute):
     return attribute.idl_type.endswith('Constructor')