Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1406423003: Move zoom property handling into CSSPropertyParser (Closed)

Created:
5 years, 2 months ago by rwlbuis
Modified:
5 years, 2 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move zoom property handling into CSSPropertyParser Move zoom property handling from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/4fccdaa3ee48a8906f5c46c17de8a6581dcc8a84 Cr-Commit-Position: refs/heads/master@{#354817}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
rwlbuis
PTAL
5 years, 2 months ago (2015-10-19 02:38:05 UTC) #2
Timothy Loh
lgtm https://codereview.chromium.org/1406423003/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1406423003/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode898 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:898: CSSParserToken token = range.peek(); const CSSParserToken& https://codereview.chromium.org/1406423003/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode910 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:910: ...
5 years, 2 months ago (2015-10-19 04:46:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406423003/20001
5 years, 2 months ago (2015-10-19 17:03:07 UTC) #6
commit-bot: I haz the power
Exceeded global retry quota
5 years, 2 months ago (2015-10-19 18:14:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406423003/20001
5 years, 2 months ago (2015-10-19 18:27:39 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-19 19:11:29 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 19:12:13 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4fccdaa3ee48a8906f5c46c17de8a6581dcc8a84
Cr-Commit-Position: refs/heads/master@{#354817}

Powered by Google App Engine
This is Rietveld 408576698