Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1406423003: Move zoom property handling into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch for landing Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
index 517c613b80c6d2adfd9e949c4732c3016a0d1ef6..421179ef9cc5b4b0e37fe3924e7965688394136d 100644
--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
@@ -699,18 +699,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
validPrimitive = (id == CSSValueAuto || id == CSSValueUnder);
break;
- case CSSPropertyZoom: // normal | reset | document | <number> | <percentage> | inherit
- if (id == CSSValueNormal || id == CSSValueReset || id == CSSValueDocument)
- validPrimitive = true;
- else
- validPrimitive = validUnit(value, FNumber | FPercent | FNonNeg);
- if (validPrimitive && m_context.useCounter()
- && !(id == CSSValueNormal
- || (value->unit() == CSSPrimitiveValue::UnitType::Number && value->fValue == 1)
- || (value->unit() == CSSPrimitiveValue::UnitType::Percentage && value->fValue == 100)))
- m_context.useCounter()->count(UseCounter::CSSZoomNotEqualToOne);
- break;
-
case CSSPropertySrc:
case CSSPropertyUnicodeRange:
/* @font-face only descriptors */
@@ -1267,6 +1255,7 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
case CSSPropertyWebkitColumns:
case CSSPropertyWebkitColumnGap:
case CSSPropertyWebkitColumnSpan:
+ case CSSPropertyZoom:
validPrimitive = false;
break;
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698