Issue 1406333006: Revert of Suppression for valgrind bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1406333006: Revert of Suppression for valgrind bug (Closed)

Created:
5 years, 2 months ago by scroggo

Modified:
5 years, 2 months ago

Reviewers:
msarett

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Suppression for valgrind bug (patchset #1 id:1 of https://codereview.chromium.org/1410953002/ ) Reason for revert: We believe this was suppressing an out of date error that was being triggered because the valgrind bot was not rebuilding nanobench. The valgrind bot has been fixed (is there a bug tracking that?), so this suppression is probably not necessary. Original issue's description: > Suppression for valgrind bug > > TBR=msarett@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > BUG=skia:4478 > > Committed: https://skia.googlesource.com/skia/+/82e341ff8764ef6168a0c9322089c391d657ae7f TBR=msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4478 Committed: https://skia.googlesource.com/skia/+/7f53819ea9f8317b4bae1d54239b5b4c18240ef0

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	tools/valgrind.supp	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406333006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406333006/1

5 years, 2 months ago (2015-10-22 14:23:15 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-22 14:23:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7f53819ea9f8317b4bae1d54239b5b4c18240ef0

Expand Messages | Collapse Messages