gpu: Recompute driver bug workarounds on linux

gpu: Recompute driver bug workarounds on linux

It was discoverd that certain workarounds were not being enabled
when called from by webgl conformance tests. This happened because
some workarounds, such as virtual context, require additional
information from the driver.  Normally we get this from cached info.
but since conformance tests start clean, there is no cache.

Chromeos and android, we were recomputing the driver bug
workarounds, and now we do the same thing on linux.

There will be a bit of additional cost, but at least it will be
correct,

BUG=546281
Committed: https://crrev.com/e45d4470b8392b15e58829dd19b2e6ae1fc32af3
Cr-Commit-Position: refs/heads/master@{#355610}

[hendrikw, 2015-10-22 17:26:41]

hendrikw@chromium.org changed reviewers:
+ kbr@chromium.org

[hendrikw, 2015-10-22 17:26:41]

PTAL, thanks!

[hendrikw, 2015-10-22 17:27:36]

Description was changed from

==========
gpu: Recompute driver bug workarounds on linux

It was discoverd that certain workarounds were not being enabled
when called from by webgl conformance tests. This happened because
some workarounds, such as virtual context, require additional
information from the driver.  Normally we get this from cached info,
but since conformance tests start clean, there is no cache.

Chromeos and android, we were recomputing the driver bug
workarounds, and now we do the same thing on linux.

There will be a bit of additional cost, but at least it will be
correct,

BUG=546281
==========

to

==========
gpu: Recompute driver bug workarounds on linux

It was discoverd that certain workarounds were not being enabled
when called from by webgl conformance tests. This happened because
some workarounds, such as virtual context, require additional
information from the driver.  Normally we get this from cached info.
but since conformance tests start clean, there is no cache.

Chromeos and android, we were recomputing the driver bug
workarounds, and now we do the same thing on linux.

There will be a bit of additional cost, but at least it will be
correct,

BUG=546281
==========

[Ken Russell (switch to Gerrit), 2015-10-22 17:30:32]

kbr@chromium.org changed reviewers:
+ zmo@chromium.org

[Ken Russell (switch to Gerrit), 2015-10-22 17:30:32]

lgtm, though I wish there were a way to test this

https://codereview.chromium.org/1406323005/diff/1/content/gpu/gpu_main.cc
File content/gpu/gpu_main.cc (right):

https://codereview.chromium.org/1406323005/diff/1/content/gpu/gpu_main.cc#new...
content/gpu/gpu_main.cc:297: // on systems where vendor_id/device_id aren't
available.
Could you please expand this comment? "This is necessary on systems where
vendor_id/device_id aren't available (Chrome OS, Android) or where workarounds
may be dependent on GL_VENDOR and GL_RENDERER strings which are lazily computed
(Linux)."

[hendrikw, 2015-10-22 18:05:13]

Done, as for a test, hopefully we can sort this out with crbug.com/546641

[Ken Russell (switch to Gerrit), 2015-10-22 18:27:17]

Thanks, still LGTM.

[hendrikw, 2015-10-22 18:27:53]

The CQ bit was checked by hendrikw@chromium.org

[commit-bot: I haz the power, 2015-10-22 18:29:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406323005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406323005/20001

[commit-bot: I haz the power, 2015-10-22 19:38:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-22 19:39:30]

Patchset 2 (id:??) landed as
https://crrev.com/e45d4470b8392b15e58829dd19b2e6ae1fc32af3
Cr-Commit-Position: refs/heads/master@{#355610}