[tracing] Add names to memory-infra dumpers for debugging

[tracing] Add names to memory-infra dumpers for debugging

Follow-up CL to crrev.com/1425793002. Adds an extra |name|
argument to the memory-infra RegisterDumpProvider methods.
This allow to see the names of the dump providers in the trace
and diagnose dump providers getting stuck or taking more time
than usual.
No further behavioral change is introduced by this CL.

BUG=547764
TBR=xhwang@chromium.org,simonhatch@chromium.org,jochen@chromium.org,shess@chromium.org,piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/186d6bfe41254d6e453a82bed9c8714b70b2af67
Cr-Commit-Position: refs/heads/master@{#357089}

[Primiano Tucci (use gerrit), 2015-10-27 16:49:56]

primiano@chromium.org changed reviewers:
+ petrcermak@chromium.org, rbyers@chromium.org

[Primiano Tucci (use gerrit), 2015-10-27 16:49:56]

+rbyers for the change to 	third_party/WebKit/public/platform/Platform.h
+petrcermak for a general review

I'll TBR all the rest of the owners as this is really mechanical and not worth
anybody else's time.

[Rick Byers, 2015-10-27 16:57:19]

WebKit/public/platform LGTM

[haraken, 2015-10-27 17:00:06]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-10-27 17:00:06]

Source/* LGTM

https://codereview.chromium.org/1406213005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebKit.cpp (right):

https://codereview.chromium.org/1406213005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebKit.cpp:127:
platform->registerMemoryDumpProvider(WebCacheMemoryDumpProvider::instance(),
"WebCache");

"WebCache" => "MemoryCache"

[Primiano Tucci (use gerrit), 2015-10-27 17:03:19]

+ericrk FYI (just realised that half of the dumpers are yours here :) )

https://codereview.chromium.org/1406213005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebKit.cpp (right):

https://codereview.chromium.org/1406213005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebKit.cpp:127:
platform->registerMemoryDumpProvider(WebCacheMemoryDumpProvider::instance(),
"WebCache");
On 2015/10/27 17:00:06, haraken wrote:
> 
> "WebCache" => "MemoryCache"

Done.

[petrcermak, 2015-10-27 18:06:15]

My only comment is that the names (e.g. "TraceLog") don't fully match the names
of MemoryAllocatorDumps they produce (e.g. "tracing"). It's not a major issue,
but it would be nice if they were consistent.

Apart from that, LGTM.

Thanks,
Petr

[Primiano Tucci (use gerrit), 2015-10-29 10:44:39]

On 2015/10/27 18:06:15, petrcermak wrote:
> My only comment is that the names (e.g. "TraceLog") don't fully match the
names
> of MemoryAllocatorDumps they produce (e.g. "tracing"). It's not a major issue,
> but it would be nice if they were consistent.
> 
> Apart from that, LGTM.
> 
> Thanks,
> Petr

I know, but unfortunately that is tricky:
 - some dumpers produce multiple root-level dumps (cc, gpu)
 - many dumpers produce data within the same root-level dump (the various
gpu/graphics dumpers)
 - some dumpers don't produce a MAD at all (totals, mmaps)

So I just went for the class name in the c++ code, to make it easier to lookup
in codesearch

[Primiano Tucci (use gerrit), 2015-10-29 15:36:55]

Description was changed from

==========
[tracing] Add names to memory-infra dumpers for debugging

Follow-up CL to crrev.com/1425793002. Adds an extra |name|
argument to the memory-infra RegisterDumpProvider methods.
This allow to see the names of the dump providers in the trace
and diagnose dump providers getting stuck or taking more time
than usual.
No further behavioral change is introduced by this CL.

BUG=547764
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
[tracing] Add names to memory-infra dumpers for debugging

Follow-up CL to crrev.com/1425793002. Adds an extra |name|
argument to the memory-infra RegisterDumpProvider methods.
This allow to see the names of the dump providers in the trace
and diagnose dump providers getting stuck or taking more time
than usual.
No further behavioral change is introduced by this CL.

BUG=547764
TBR=xhwang@chromium.org,simonhatch@chromium.org,jochen@chromium.org,shess@chr...
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Primiano Tucci (use gerrit), 2015-10-29 15:38:26]

TBR due to the mechanical nature of the change

wang: for media/
simonhatch: for tracing (base/ and components/)
jochen: for content/ and gin/
shess: for sql/connection.cc
piman: for cc/ and gpu/

[Primiano Tucci (use gerrit), 2015-10-29 15:38:35]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-10-29 15:38:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, rbyers@chromium.org, petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/1406213005/#ps80001
(title: "Ah, tests")

[commit-bot: I haz the power, 2015-10-29 15:39:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406213005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406213005/80001

[commit-bot: I haz the power, 2015-10-29 15:45:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 15:45:38]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Primiano Tucci (use gerrit), 2015-10-30 09:43:24]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-10-30 09:43:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, rbyers@chromium.org, petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/1406213005/#ps100001
(title: "Rebase + fix android")

[commit-bot: I haz the power, 2015-10-30 09:43:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406213005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406213005/100001

[commit-bot: I haz the power, 2015-10-30 13:21:48]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-30 13:22:47]

Patchset 6 (id:??) landed as
https://crrev.com/186d6bfe41254d6e453a82bed9c8714b70b2af67
Cr-Commit-Position: refs/heads/master@{#357089}