Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: third_party/WebKit/public/platform/Platform.h

Issue 1406213005: [tracing] Add names to memory-infra dumpers for debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@memory-infra-runtime
Patch Set: Rebase + fix android Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebKit.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
567 // Unlike enumeration histograms, sparse histograms only allocate memory for non-empty buckets. 567 // Unlike enumeration histograms, sparse histograms only allocate memory for non-empty buckets.
568 virtual void histogramSparse(const char* name, int sample) { } 568 virtual void histogramSparse(const char* name, int sample) { }
569 569
570 // Record to a RAPPOR privacy-preserving metric, see: https://www.chromium.o rg/developers/design-documents/rappor. 570 // Record to a RAPPOR privacy-preserving metric, see: https://www.chromium.o rg/developers/design-documents/rappor.
571 // recordRappor records a sample string, while recordRapporURL records the d omain and registry of a url. 571 // recordRappor records a sample string, while recordRapporURL records the d omain and registry of a url.
572 virtual void recordRappor(const char* metric, const WebString& sample) { } 572 virtual void recordRappor(const char* metric, const WebString& sample) { }
573 virtual void recordRapporURL(const char* metric, const blink::WebURL& url) { } 573 virtual void recordRapporURL(const char* metric, const blink::WebURL& url) { }
574 574
575 // Registers a memory dump provider. The WebMemoryDumpProvider::onMemoryDump 575 // Registers a memory dump provider. The WebMemoryDumpProvider::onMemoryDump
576 // method will be called on the same thread that called the 576 // method will be called on the same thread that called the
577 // registerMemoryDumpProvider() method. 577 // registerMemoryDumpProvider() method. |name| is used for debugging
578 // (duplicates are allowed) and must be a long-lived C string.
578 // See crbug.com/458295 for design docs. 579 // See crbug.com/458295 for design docs.
579 virtual void registerMemoryDumpProvider(blink::WebMemoryDumpProvider*) { } 580 virtual void registerMemoryDumpProvider(blink::WebMemoryDumpProvider*, const char* name) { }
580 581
581 // Must be called on the thread that called registerMemoryDumpProvider(). 582 // Must be called on the thread that called registerMemoryDumpProvider().
582 virtual void unregisterMemoryDumpProvider(blink::WebMemoryDumpProvider*) { } 583 virtual void unregisterMemoryDumpProvider(blink::WebMemoryDumpProvider*) { }
583 584
584 // Returns a newly allocated WebProcessMemoryDump instance. 585 // Returns a newly allocated WebProcessMemoryDump instance.
585 virtual blink::WebProcessMemoryDump* createProcessMemoryDump() { return null ptr; } 586 virtual blink::WebProcessMemoryDump* createProcessMemoryDump() { return null ptr; }
586 587
587 typedef uint64_t WebMemoryAllocatorDumpGuid; 588 typedef uint64_t WebMemoryAllocatorDumpGuid;
588 589
589 // Returns guid corresponding to the given string (the hash value) for 590 // Returns guid corresponding to the given string (the hash value) for
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 protected: 737 protected:
737 BLINK_PLATFORM_EXPORT Platform(); 738 BLINK_PLATFORM_EXPORT Platform();
738 virtual ~Platform() { } 739 virtual ~Platform() { }
739 740
740 WebThread* m_mainThread; 741 WebThread* m_mainThread;
741 }; 742 };
742 743
743 } // namespace blink 744 } // namespace blink
744 745
745 #endif 746 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebKit.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698