Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1406183010:
Replace ARRAY_SIZE with WTF_ARRAY_LENGTH (Closed)
DescriptionReplace ARRAY_SIZE with WTF_ARRAY_LENGTH
These two macros do the same thing.
BUG=548217
Committed: https://crrev.com/799e0bc8eeea9457f5f97e1674ccb15cc889bb1f
Cr-Commit-Position: refs/heads/master@{#361276}
Patch Set 1 #
Total comments: 2
Patch Set 2 : #
Messages
Total messages: 38 (16 generated)
haraken@chromium.org changed reviewers: + esprehn@chromium.org
PTAL
urvang@chromium.org changed reviewers: + urvang@chromium.org
lgtm LGTM for image-decoders
haraken@chromium.org changed reviewers: + tasak@google.com
+tasak: PTAL. This is just a renaming change.
lgtm
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406183010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406183010/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406183010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406183010/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406183010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406183010/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406183010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406183010/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
tfarina@chromium.org changed reviewers: + tfarina@chromium.org
Do you plan to go back to this?
You renamed a webgl idl attribute which broke all the tests. :) https://codereview.chromium.org/1406183010/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl (right): https://codereview.chromium.org/1406183010/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl:398: const GLenum VERTEX_ATTRIB_WTF_ARRAY_LENGTH = 0x8623; This is wrong, you're changing the web exposed API.
https://codereview.chromium.org/1406183010/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl (right): https://codereview.chromium.org/1406183010/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl:398: const GLenum VERTEX_ATTRIB_WTF_ARRAY_LENGTH = 0x8623; On 2015/11/20 22:48:03, esprehn wrote: > This is wrong, you're changing the web exposed API. Done.
The CQ bit was checked by haraken@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tasak@google.com, urvang@chromium.org Link to the patchset: https://codereview.chromium.org/1406183010/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406183010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406183010/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by haraken@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406183010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406183010/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/799e0bc8eeea9457f5f97e1674ccb15cc889bb1f Cr-Commit-Position: refs/heads/master@{#361276}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
