Loosen requirement that there be only one GrDrawTarget

Loosen requirement that there be only one GrDrawTarget

BUG=skia:4094
Committed: https://skia.googlesource.com/skia/+/a106c627532ad669cf7d879955ae8ea6a53233c1

[robertphillips, 2015-10-16 13:34:34]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2015-10-16 13:56:34]

Mostly seems fine. I'm not big on "DT", would prefer using the full "DrawTarget"

Does DrawTarget ever escape a DrawContext? It seems like it'd be nice if it
didn't.

I'm wondering if we need the shimming of Mgr methods through Context. Could DCs
have a pointer to their Mgr and then not to go through context for Mgr's
facilities? Or make the Mgr be accessible from Context (but be defined in a
private header)?

[robertphillips, 2015-10-16 15:11:17]

Mainly for posterity:

getDT has been renamed getDrawTarget

The drawTargets should be enclosed by the DrawingMgr and the drawContexts.

I will remove the shims in a follow-on patch.

[bsalomon, 2015-10-16 15:18:31]

On 2015/10/16 15:11:17, robertphillips wrote:
> Mainly for posterity:
> 
> getDT has been renamed getDrawTarget

Can we do the other DT methods as well. Pretty please. (lastDT(), newDT())

> 
> The drawTargets should be enclosed by the DrawingMgr and the drawContexts.
> 
> I will remove the shims in a follow-on patch.

[robertphillips, 2015-10-16 15:29:07]

On 2015/10/16 15:18:31, bsalomon wrote:
> On 2015/10/16 15:11:17, robertphillips wrote:
> > Mainly for posterity:
> > 
> > getDT has been renamed getDrawTarget
> 
> Can we do the other DT methods as well. Pretty please. (lastDT(), newDT())
> 
> > 
> > The drawTargets should be enclosed by the DrawingMgr and the drawContexts.
> > 
> > I will remove the shims in a follow-on patch.

Whoops - forgot about those. Latest patch fixes them too.

[bsalomon, 2015-10-16 15:55:25]

lgtm

[robertphillips, 2015-10-16 15:57:15]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-16 15:57:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406173003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406173003/60001

[commit-bot: I haz the power, 2015-10-16 16:06:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 16:06:12]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-10-16 16:06:18]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-10-16 16:06:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406173003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406173003/60001

[commit-bot: I haz the power, 2015-10-16 16:07:09]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/a106c627532ad669cf7d879955ae8ea6a53233c1