Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1406153011: Add EOR(register) and EOR(immediate) to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add EOR(register) and EOR(immediate) to ARM integrated assembler. Also factor out code to process arguments for data operations into new method Arm32::Assembler32::emitType01(). BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=62d367bdc5f04368566e6e67f4f1b801a225b14d

Patch Set 1 #

Patch Set 2 : Merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -200 lines) Patch
M src/DartARM32/assembler_arm.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/IceAssemblerARM32.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 5 chunks +131 lines, -198 lines 0 comments Download
M src/IceInstARM32.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
A tests_lit/assembler/arm32/eor.ll View 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Karl
5 years, 1 month ago (2015-10-29 22:48:33 UTC) #3
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-10-30 00:17:03 UTC) #4
Karl
5 years, 1 month ago (2015-10-30 15:06:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
62d367bdc5f04368566e6e67f4f1b801a225b14d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698