Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1406153003: CSS Font Loading: drop readonly to use Setlike functionalities (Closed)

Created:
5 years, 2 months ago by Takashi Toyoshima
Modified:
5 years, 2 months ago
CC:
chromium-reviews, vivekg_samsung, blink-reviews-css, vivekg, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, blink-reviews, rwlbuis, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@font_face_set
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Font Loading: drop readonly to use Setlike functionalities FontFaceSet.idl used readonly setlike<FontFace> to use existing add(), delete(), and clear() implementations. This patch drops readonly to use binding scheme to implement writable Setlike methods. Note that add() method returns FontFaceSet after this change. BUG=392075 Committed: https://crrev.com/570fb77ac846fb6f52c67e14245e254d1ae9db43 Cr-Commit-Position: refs/heads/master@{#354947}

Patch Set 1 #

Patch Set 2 : done #

Patch Set 3 : test #

Patch Set 4 : use shouldBeCloseTo #

Patch Set 5 : insert <br> #

Messages

Total messages: 12 (3 generated)
Takashi Toyoshima
Sakamoto-san, can you take a look? This is the second and the last patch to ...
5 years, 2 months ago (2015-10-19 09:30:39 UTC) #2
Kunihiko Sakamoto
lgtm
5 years, 2 months ago (2015-10-19 09:48:20 UTC) #3
Takashi Toyoshima
haraken@chromium.org: Please review changes in core/. tkent@chromium.org: Please review changes in FontFaceSet.idl
5 years, 2 months ago (2015-10-19 13:29:08 UTC) #5
Takashi Toyoshima
cc: philipj since this change fixes a TODO(philipj)
5 years, 2 months ago (2015-10-19 13:30:36 UTC) #6
haraken
core/ LGTM
5 years, 2 months ago (2015-10-19 14:16:18 UTC) #7
tkent
> Note that add() method returns FontFaceSet after this change. The change is trivial. LGTM
5 years, 2 months ago (2015-10-19 23:21:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406153003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406153003/80001
5 years, 2 months ago (2015-10-20 01:07:37 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-20 01:14:04 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 01:15:25 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/570fb77ac846fb6f52c67e14245e254d1ae9db43
Cr-Commit-Position: refs/heads/master@{#354947}

Powered by Google App Engine
This is Rietveld 408576698