third_party/WebKit/Source/core/css/FontFaceSet.h - Issue 1406153003: CSS Font Loading: drop readonly to use Setlike functionalities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontFaceSet.h

Issue 1406153003: CSS Font Loading: drop readonly to use Setlike functionalities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@font_face_set

Patch Set: insert <br> Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win-xp/fast/css/fontfaceset-add-remove-expected.txt ('k') | third_party/WebKit/Source/core/css/FontFaceSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/FontFaceSet.h

diff --git a/third_party/WebKit/Source/core/css/FontFaceSet.h b/third_party/WebKit/Source/core/css/FontFaceSet.h

index 279e9a0162a6726445ced7e5a6acb14705178288..434c6750e73d4e657e54125ac63940d3477c652f 100644

--- a/third_party/WebKit/Source/core/css/FontFaceSet.h

+++ b/third_party/WebKit/Source/core/css/FontFaceSet.h

@@ -81,9 +81,9 @@ public:

ScriptPromise load(ScriptState*, const String& font, const String& text);

ScriptPromise ready(ScriptState*);

- void add(FontFace*, ExceptionState&);

- void clear();

- bool remove(FontFace*, ExceptionState&);

+ PassRefPtrWillBeRawPtr<FontFaceSet> addForBinding(ScriptState*, FontFace*, ExceptionState&);

+ void clearForBinding(ScriptState*, ExceptionState&);

+ bool deleteForBinding(ScriptState*, FontFace*, ExceptionState&);

bool hasForBinding(ScriptState*, FontFace*, ExceptionState&) const;

size_t size() const;