Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1406103006: Also fix new tab button background alignment. (Closed)

Created:
5 years, 1 month ago by Peter Kasting
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Also fix new tab button background alignment. This was supposed to be in https://codereview.chromium.org/1430553004 but was accidentally left out. It matches the change there in Tab::PaintInactiveTabBackground(). BUG=none TEST=Apply the "Dots" theme from the webstore and open a restored-mode window; the alignment of the background images in the frame and new tab button should match. TBR=sky Committed: https://chromium.googlesource.com/chromium/src/+/db6a2f07dbc59f8890bad06e94353270bf75f54d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
5 years, 1 month ago (2015-11-10 01:31:35 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/db6a2f07dbc59f8890bad06e94353270bf75f54d Cr-Commit-Position: refs/heads/master@{#358734}
5 years, 1 month ago (2015-11-10 01:37:20 UTC) #2
Peter Kasting
Committed patchset #1 (id:1) manually as db6a2f07dbc59f8890bad06e94353270bf75f54d (presubmit successful).
5 years, 1 month ago (2015-11-10 01:37:48 UTC) #3
sky
5 years, 1 month ago (2015-11-10 18:47:46 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698