Make chrome/common pass "gn check"

Make chrome/common pass "gn check"

This adds some dependencies and marks them all public. Since chrome/common doesn't have much of an API or structure, deciding what should be public or not is basically impossible.

Removes the include of content_switches from chrome_switches. Files depending on this have already been updated to include content_switches directly.

Moves the nss_security_manager code out of chrome_browser. This was used only by chrome_common. In GYP This is now part of chrome_common_net. In GN, this is a separate target that chrome_common_net depends on.

Reland of https://codereview.chromium.org/1393953003/
TBR=dpranke

Committed: https://crrev.com/0b9c96b1b27fe9d92d741dddff1c9cb87cf3bee2
Cr-Commit-Position: refs/heads/master@{#354391}

[brettw, 2015-10-15 22:09:31]

This was reverted because of the include of chrome/grit/generated_resources.h
which is generated, but the dependency from the mozilla_security_manager to the
target that generated the header was missing.

The new patch adds mozilla_security_manager to "gn check" and adds the missing
includes this detects.

[brettw, 2015-10-15 22:09:35]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-10-15 22:11:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406053002/20001

[commit-bot: I haz the power, 2015-10-15 22:16:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 22:16:59]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2015-10-15 22:27:20]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-10-15 22:27:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406053002/20001

[commit-bot: I haz the power, 2015-10-15 23:06:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-15 23:07:12]

Patchset 2 (id:??) landed as
https://crrev.com/0b9c96b1b27fe9d92d741dddff1c9cb87cf3bee2
Cr-Commit-Position: refs/heads/master@{#354391}

[Dirk Pranke, 2015-10-16 01:18:23]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-10-16 01:18:24]

lgtm