Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: chrome/common/crash_keys.cc

Issue 1406053002: Make chrome/common pass "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/chrome_switches.h ('k') | chrome/common/net/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/crash_keys.h" 5 #include "chrome/common/crash_keys.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/strings/string_split.h" 11 #include "base/strings/string_split.h"
12 #include "base/strings/string_util.h" 12 #include "base/strings/string_util.h"
13 #include "base/strings/stringprintf.h" 13 #include "base/strings/stringprintf.h"
14 #include "base/strings/utf_string_conversions.h" 14 #include "base/strings/utf_string_conversions.h"
15 #include "chrome/common/chrome_switches.h" 15 #include "chrome/common/chrome_switches.h"
16 #include "content/public/common/content_switches.h" 16 #include "content/public/common/content_switches.h"
17 #include "ipc/ipc_switches.h" 17 #include "ipc/ipc_switches.h"
18 18
19 // Breakpad dependencies exist only on Windows and Mac desktop. Exclude them
20 // from "gn check" to avoid failures on Linux (it doesn't understand ifdefs).
19 #if defined(OS_MACOSX) 21 #if defined(OS_MACOSX)
20 #include "breakpad/src/common/simple_string_dictionary.h" 22 #include "breakpad/src/common/simple_string_dictionary.h" // nogncheck
21 #elif defined(OS_WIN) 23 #elif defined(OS_WIN)
22 #include "breakpad/src/client/windows/common/ipc_protocol.h" 24 #include "breakpad/src/client/windows/common/ipc_protocol.h" // nogncheck
23 #elif defined(OS_CHROMEOS) 25 #elif defined(OS_CHROMEOS)
24 #include "chrome/common/chrome_switches.h" 26 #include "chrome/common/chrome_switches.h"
25 #include "gpu/command_buffer/service/gpu_switches.h" 27 #include "gpu/command_buffer/service/gpu_switches.h"
26 #include "ui/gl/gl_switches.h" 28 #include "ui/gl/gl_switches.h"
27 #endif 29 #endif
28 30
29 namespace crash_keys { 31 namespace crash_keys {
30 32
31 // The maximum lengths specified by breakpad include the trailing NULL, so 33 // The maximum lengths specified by breakpad include the trailing NULL, so
32 // the actual length of the string is one less. 34 // the actual length of the string is one less.
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 } 359 }
358 360
359 ScopedPrinterInfo::~ScopedPrinterInfo() { 361 ScopedPrinterInfo::~ScopedPrinterInfo() {
360 for (size_t i = 0; i < kPrinterInfoCount; ++i) { 362 for (size_t i = 0; i < kPrinterInfoCount; ++i) {
361 std::string key = base::StringPrintf(kPrinterInfo, i + 1); 363 std::string key = base::StringPrintf(kPrinterInfo, i + 1);
362 base::debug::ClearCrashKey(key); 364 base::debug::ClearCrashKey(key);
363 } 365 }
364 } 366 }
365 367
366 } // namespace crash_keys 368 } // namespace crash_keys
OLDNEW
« no previous file with comments | « chrome/common/chrome_switches.h ('k') | chrome/common/net/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698