Issue 1406013005: Split the //mojo/public/cpp/test_support:test_utils target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1406013005: Split the //mojo/public/cpp/test_support:test_utils target. (Closed)

Created:
5 years, 1 month ago by viettrungluu

Modified:
5 years, 1 month ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Split the //mojo/public/cpp/test_support:test_utils target. The test_support target depends on //mojo/public/c/test_support, while test_utils doesn't. (The naming is slightly dubious/confusing, but it's consistent with the current situation.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5e6a8389326fa4c20836e7ede0481c99e0bf27df

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -40 lines)			Patch
M	mojo/public/c/system/tests/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/cpp/bindings/tests/BUILD.gn	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	mojo/public/cpp/bindings/tests/binding_callback_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/public/cpp/bindings/tests/bindings_perftest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/public/cpp/system/tests/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/public/cpp/test_support/BUILD.gn	View	2 chunks	+15 lines, -8 lines	0 comments	Download
M	mojo/public/cpp/test_support/lib/test_utils.cc	View	3 chunks	+10 lines, -24 lines	0 comments	Download
M	mojo/tests/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/tests/task_tracker_perftest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 1 month ago (2015-10-26 21:04:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5e6a8389326fa4c20836e7ede0481c99e0bf27df (presubmit successful).

Expand Messages | Collapse Messages