Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: mojo/public/cpp/test_support/BUILD.gn

Issue 1406013005: Split the //mojo/public/cpp/test_support:test_utils target. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/system/tests/BUILD.gn ('k') | mojo/public/cpp/test_support/lib/test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/test_support/BUILD.gn
diff --git a/mojo/public/cpp/test_support/BUILD.gn b/mojo/public/cpp/test_support/BUILD.gn
index a1f7d3126ee121a0dc705d86aa93ecec43b13d8e..016aa957cd2f3fe1221998bf79a8fcac1ce6b53f 100644
--- a/mojo/public/cpp/test_support/BUILD.gn
+++ b/mojo/public/cpp/test_support/BUILD.gn
@@ -4,18 +4,13 @@
import("../../mojo_sdk.gni")
-# GYP version: mojo/public/mojo_public.gyp:mojo_public_test_utils
-mojo_sdk_source_set("test_utils") {
+# This target depends on mojo/public/c/test_support.
+mojo_sdk_source_set("test_support") {
testonly = true
sources = [
"lib/test_support.cc",
- "lib/test_utils.cc",
- "test_utils.h",
- ]
-
- deps = [
- "//testing/gtest",
+ "test_support.h",
]
mojo_sdk_deps = [
@@ -23,3 +18,15 @@ mojo_sdk_source_set("test_utils") {
"mojo/public/cpp/system",
]
}
+
+# This target should be "pure Mojo" and have no external dependencies.
+mojo_sdk_source_set("test_utils") {
+ testonly = true
+
+ sources = [
+ "lib/test_utils.cc",
+ "test_utils.h",
+ ]
+
+ mojo_sdk_deps = [ "mojo/public/cpp/system" ]
+}
« no previous file with comments | « mojo/public/cpp/system/tests/BUILD.gn ('k') | mojo/public/cpp/test_support/lib/test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698